Skip to content

simlify core symbol config#148

Open
vadim-di wants to merge 10 commits intoeoscanada:masterfrom
vadim-di:vadim-di-patch-1
Open

simlify core symbol config#148
vadim-di wants to merge 10 commits intoeoscanada:masterfrom
vadim-di:vadim-di-patch-1

Conversation

@vadim-di
Copy link

@vadim-di vadim-di commented Oct 1, 2019

No description provided.

@maoueh
Copy link
Contributor

maoueh commented Oct 1, 2019

Two things.

  • You made some changes to CLI flag, those should be made in a separate pull request for proper discussion.
  • Your simplification removes all the previous code that was making an API call to infer the proper symbol based on the API endpoint hit. All this logic must still apply.

What you use case for this? Complete off-line usage?

@vadim-di
Copy link
Author

vadim-di commented Oct 1, 2019

I've found its not actually use flag --core-symbol trying to fetch it from chain. And the decimal point do not change if I decide to transfer other tokens like BNT. You can drop CLI changes, but do something with symbol and decimals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants