[oh-tab-a1g] Docs: WS header auth (no URL secrets)#874
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughDocumentation updated to prefer header-based authentication (X-Session-API-Key or Authorization: Bearer) for HTTP and WebSocket handshakes in non-browser contexts, while preserving a legacy ?session_api_key query-parameter fallback for browser WebSocket usage and clarifying cloud vs runtime/session token roles. Changes
Sequence Diagram(s)(omitted — documentation-only changes; no new multi-component control flow introduced) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@docs/cloud-auth-flow.md`:
- Around line 26-34: Replace the bolded "Related work (Jan 22, 2026)" line with
a proper Markdown heading (e.g., "## Related work (Jan 22, 2026)" or "###
Related work (Jan 22, 2026)") so MD036 is satisfied and the section matches the
doc's other headings; update the line that currently reads "**Related work (Jan
22, 2026)**" to a heading-level line and ensure the surrounding list items and
paragraphs remain unchanged.
In `@docs/settings_prd.md`:
- Around line 24-26: Add a short clarifying sentence next to the "WebSocket:
prefer handshake header auth" line and/or adjacent to the WS URL example to
state that the `?session_api_key=<runtimeSessionApiKey>` query parameter is
legacy-only (browser-only) and will be removed upstream; reference the
`session_api_key` token explicitly so readers know the query-param example is
deprecated and header auth (`X-Session-API-Key` or `Authorization: Bearer ...`)
is the recommended approach.
🔧 VSCode Extension Built Successfully• File: openhands-tab-0.8.0.vsix (526 KB) To install:
Built with Node 22. Commit 2386509. |
Fixes oh-tab-a1g.
Updates cloud auth / agent-server protocol docs to reflect the security posture: no secrets in WS URLs.
X-Session-API-Key/Authorization: Bearer ...).?session_api_key=...documented only as a legacy browser constraint.Notes
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.