Add optional rate limit key config for Envoy override stats keys#1153
Open
andreaaliu wants to merge 6 commits into
Open
Add optional rate limit key config for Envoy override stats keys#1153andreaaliu wants to merge 6 commits into
andreaaliu wants to merge 6 commits into
Conversation
Signed-off-by: andrea liu <andrealiu@Roblox.com>
Signed-off-by: andrea liu <andrealiu@Roblox.com>
andreaaliu
force-pushed
the
feature/ratelimit-override-descriptor-key-config
branch
from
afa05f6 to
1117d0e
Compare
Signed-off-by: andrea liu <andrealiu@Roblox.com>
Signed-off-by: andrea liu <andrealiu@Roblox.com>
andreaaliu
force-pushed
the
feature/ratelimit-override-descriptor-key-config
branch
from
09123c2 to
656c0bf
Compare
Signed-off-by: andrea liu <andrealiu@Roblox.com>
Author
|
Hi @envoyproxy/ratelimit-maintainers, could I please get a review? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DESCRIPTOR_KEY_CONFIGYAML to control which descriptor entry values are included in stats keys for Envoy limit overrides.Motivation
value_to_metric/detailed_metricapply to config-matched limits, but override descriptors always include every entry value in the stats key, which causes high metric cardinality. #1132