fix(issue-discovery): zero stale per-repo issue fields on scoring path#1622
Open
nghetienhiep wants to merge 1 commit into
Open
fix(issue-discovery): zero stale per-repo issue fields on scoring path#1622nghetienhiep wants to merge 1 commit into
nghetienhiep wants to merge 1 commit into
Conversation
The scoring path (_finalize_repo_issue_scores) only rewrote repos seen this round, so a repo issue-scored in a prior round but absent this round kept stale per-repo values that _roll_up_issue_totals summed back into the round-level totals. This is reachable when an OSS-fetch-failed miner is restored from the evaluation cache. Extract the per-repo reset into a shared helper and apply it on both the no-issues and scoring paths so the roll-up reflects only this round's issues. Closes entrius#1610
nghetienhiep
force-pushed
the
fix/issue-1610
branch
from
1ab0774 to
28e8508
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scoring path (_finalize_repo_issue_scores) only rewrote repos seen
this round, so a repo issue-scored in a prior round but absent this round
kept stale per-repo values that _roll_up_issue_totals summed back into the
round-level totals. This is reachable when an OSS-fetch-failed miner is
restored from the evaluation cache. Extract the per-repo reset into a
shared helper and apply it on both the no-issues and scoring paths so the
roll-up reflects only this round's issues.
Closes #1610