fix(scoring): attribute merged PR repo before mirror file-fetch early returns#1621
Open
nghetienhiep wants to merge 1 commit into
Open
fix(scoring): attribute merged PR repo before mirror file-fetch early returns#1621nghetienhiep wants to merge 1 commit into
nghetienhiep wants to merge 1 commit into
Conversation
… returns score_pr() only added a MERGED PR's repo to unique_repos_contributed_to after the transient file-fetch early returns (scoring_data_stored=False, MirrorRequestError, empty files), so a merged PR could count toward eligibility but silently miss unique-repo attribution based purely on mirror timing. Move the attribution ahead of those branches. Regression of entrius#65/entrius#71 reintroduced when scoring moved to the mirror path. Closes entrius#1616
nghetienhiep
force-pushed
the
fix/issue-1616
branch
2 times, most recently
from
93a822a to
c540d9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
score_pr() only added a MERGED PR's repo to unique_repos_contributed_to after
the transient file-fetch early returns (scoring_data_stored=False,
MirrorRequestError, empty files), so a merged PR could count toward eligibility
but silently miss unique-repo attribution based purely on mirror timing.
Move the attribution ahead of those branches. Regression of #65/#71 reintroduced
when scoring moved to the mirror path.
Closes #1616