feat(bounties): add inline search to mobile toolbar in IssuesList#1266
feat(bounties): add inline search to mobile toolbar in IssuesList#1266nickmopen wants to merge 1 commit into
Conversation
|
Thanks for the PR. After looking at the before/after, I don't think adding an inline search field is the right fix here. The page already has a search bar at the top of the layout. Adding a second visually-identical search input inside the toolbar means the same view ends up with two search bars stacked one above the other, which is more confusing than the original. The real issue with the sub- A better direction would be to reposition Options so the empty row doesn't exist in the first place — for example, inline with the tab row (All / Available / Pending / History), or grouped with the other header/toolbar controls — rather than introducing a duplicate search affordance to justify the row. Happy to look at a follow-up that takes that approach. |
Summary
On screens below the
xlbreakpoint (< 1536px), the/bountiestoolbar only showed an Options button — search was hidden inside a popover requiring an extra tap. This PR adds analways-visible inline search field to the toolbar so users can filter issues without opening the popover.
Changes in
src/components/issues/IssuesList.tsx:usePortaldeclaration aboveoptionsPortalFiltersso the search block can be conditionally renderedoptionsPortalFilters: search section now renders only whenusePortalis true (xl+ sidebar), removing the duplicate entry from the mobile popoverinlineToolbar: addedIssuesListSearchTextFieldfilling available width, with the Options button pinned rightreturn: moved<Card>inside<DebouncedSearchInput>so the inline search field shares the same search contextRelated Issues
Closes #808
Type of Change
Screenshots
Before — only the Options button visible in the toolbar:
After — inline search field always visible next to Options button:
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses