Conversation
PR SummaryCursor Bugbot is generating a summary for commit 77979ee. Configure here. |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the deprecated auto-commit checkpoint strategy from Entire CLI, consolidating on manual-commit as the only supported strategy and updating docs/tests/settings accordingly.
Changes:
- Deleted the auto-commit strategy implementation and its unit/integration/e2e tests.
- Updated CLI/docs/help text and architecture docs to remove auto-commit references.
- Added settings migration to automatically rewrite
strategy: "auto-commit"tomanual-commit(with a warning).
Reviewed changes
Copilot reviewed 43 out of 43 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/architecture/sessions-and-checkpoints.md | Removed auto-commit strategy documentation snippet. |
| docs/architecture/logging.md | Removed auto-commit logging source reference. |
| docs/architecture/claude-hooks-integration.md | Removed auto-commit behavior notes; clarified session state update step. |
| cmd/entire/cli/strategy/strategy.go | Removed auto-commit references from strategy interface comments. |
| cmd/entire/cli/strategy/session.go | Removed auto-commit mention from checkpoint details comment. |
| cmd/entire/cli/strategy/rewind_test.go | Removed auto-commit PreviewRewind test. |
| cmd/entire/cli/strategy/registry.go | Removed StrategyNameAutoCommit constant. |
| cmd/entire/cli/strategy/push_common.go | Removed auto-commit mention from shared push helper comment. |
| cmd/entire/cli/strategy/common.go | Removed auto-commit references and removed checkCanRewind; updated metadata-branch commit message text. |
| cmd/entire/cli/strategy/clean_test.go | Updated orphan/session-state test comment to remove auto-commit reference. |
| cmd/entire/cli/strategy/auto_commit_test.go | Deleted auto-commit unit test suite. |
| cmd/entire/cli/strategy/auto_commit.go | Deleted auto-commit strategy implementation. |
| cmd/entire/cli/status_test.go | Updated status tests to use manual-commit. |
| cmd/entire/cli/status.go | Removed internal↔display strategy mapping usage in status formatting. |
| cmd/entire/cli/setup_test.go | Updated enable/setup tests to use manual-commit. |
| cmd/entire/cli/setup.go | Removed auto-commit from enable command help/completion and simplified strategy handling. |
| cmd/entire/cli/settings/settings_test.go | Updated settings tests to reflect auto-commit → manual-commit migration. |
| cmd/entire/cli/settings/settings.go | Added migration logic + warning output for deprecated auto-commit strategy. |
| cmd/entire/cli/resume_test.go | Removed auto-commit-specific resume test; updated metadata JSON strategy field. |
| cmd/entire/cli/reset_test.go | Removed reset test for auto-commit strategy. |
| cmd/entire/cli/reset.go | Removed auto-commit guidance from reset command help text. |
| cmd/entire/cli/paths/paths.go | Updated metadata branch comment (now manual-commit only). |
| cmd/entire/cli/lifecycle.go | Removed auto-commit transcript-position tracking logic. |
| cmd/entire/cli/integration_test/worktree_test.go | Switched strategy under test to manual-commit. |
| cmd/entire/cli/integration_test/testenv_test.go | Updated expected strategies count/list after removing auto-commit. |
| cmd/entire/cli/integration_test/testenv.go | Removed auto-commit from AllStrategies() and adjusted comments. |
| cmd/entire/cli/integration_test/subagent_checkpoints_test.go | Simplified checkpoint storage verification (manual-commit only). |
| cmd/entire/cli/integration_test/rewind_test.go | Removed auto-commit-only multi-session rewind test. |
| cmd/entire/cli/integration_test/resume_test.go | Switched resume integration tests to manual-commit strategy. |
| cmd/entire/cli/integration_test/hooks_test.go | Removed auto-commit branch-commit assertions; manual-commit-only expectations. |
| cmd/entire/cli/integration_test/auto_commit_checkpoint_fix_test.go | Deleted auto-commit integration regression tests. |
| cmd/entire/cli/explain_test.go | Updated test fixtures to use manual-commit strategy string. |
| cmd/entire/cli/e2e_test/scenario_checkpoint_test.go | Removed auto-commit e2e scenario. |
| cmd/entire/cli/debug.go | Removed auto-commit debug subcommand implementation. |
| cmd/entire/cli/config_test.go | Updated config loading tests to manual-commit + migration expectations. |
| cmd/entire/cli/clean.go | Removed auto-commit-specific orphaning description. |
| cmd/entire/cli/checkpoint/checkpoint.go | Generalized task checkpoint comment (no longer auto-commit-specific). |
| README.md | Removed auto-commit from enable flag docs and troubleshooting guidance. |
| GEMINI.md | Removed auto-commit from strategy documentation and key file list. |
| CLAUDE.md | Removed auto-commit from strategy docs and clarified checkpoint ID flow. |
| .github/ISSUE_TEMPLATE/bug_report.yml | Removed auto-commit as a selectable strategy option. |
| .claude/skills/test-repo/test-harness.sh | Removed auto-commit-specific note for missing shadow branch. |
| .claude/skills/test-repo/SKILL.md | Removed auto-commit/dual from strategy descriptions and expected-results matrix. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 5 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
0f87401 to
a7a1fdf
Compare
Entire-Checkpoint: 9257c9f8b2a3
a7a1fdf to
7008ffa
Compare
0932ae8 to
6d56d6c
Compare
Entire-Checkpoint: d4a45cb7c16a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
integration/e2e tests)
Entire-Checkpoint: 9257c9f8b2a3