Skip to content

delete auto-commit strat#405

Open
gtrrz-victor wants to merge 4 commits intomainfrom
remove-auto-commit
Open

delete auto-commit strat#405
gtrrz-victor wants to merge 4 commits intomainfrom
remove-auto-commit

Conversation

@gtrrz-victor
Copy link
Contributor

@gtrrz-victor gtrrz-victor commented Feb 18, 2026

  • Remove the auto-commit strategy entirely, making manual-commit the only strategy
  • Remove the strategy registry, selection logic, and all auto-commit-specific code paths (setup prompts, debug commands,
    integration/e2e tests)
  • Add a deprecated strategy field to EntireSettings so existing settings files with "strategy": "auto-commit" don't hard-error due to DisallowUnknownFields()
  • Show a friendly note in entire status and entire doctor when a settings file still contains the unused strategy field
$entire status
Enabled (manual-commit)
Note: "strategy" in .entire/settings.json is no longer needed and can be removed.

$entire doctor
No stuck sessions found.
Note: "strategy" in .entire/settings.json is no longer needed and can be removed.

Entire-Checkpoint: 9257c9f8b2a3

Copilot AI review requested due to automatic review settings February 18, 2026 06:02
@cursor
Copy link

cursor bot commented Feb 18, 2026

PR Summary

Cursor Bugbot is generating a summary for commit 77979ee. Configure here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the deprecated auto-commit checkpoint strategy from Entire CLI, consolidating on manual-commit as the only supported strategy and updating docs/tests/settings accordingly.

Changes:

  • Deleted the auto-commit strategy implementation and its unit/integration/e2e tests.
  • Updated CLI/docs/help text and architecture docs to remove auto-commit references.
  • Added settings migration to automatically rewrite strategy: "auto-commit" to manual-commit (with a warning).

Reviewed changes

Copilot reviewed 43 out of 43 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
docs/architecture/sessions-and-checkpoints.md Removed auto-commit strategy documentation snippet.
docs/architecture/logging.md Removed auto-commit logging source reference.
docs/architecture/claude-hooks-integration.md Removed auto-commit behavior notes; clarified session state update step.
cmd/entire/cli/strategy/strategy.go Removed auto-commit references from strategy interface comments.
cmd/entire/cli/strategy/session.go Removed auto-commit mention from checkpoint details comment.
cmd/entire/cli/strategy/rewind_test.go Removed auto-commit PreviewRewind test.
cmd/entire/cli/strategy/registry.go Removed StrategyNameAutoCommit constant.
cmd/entire/cli/strategy/push_common.go Removed auto-commit mention from shared push helper comment.
cmd/entire/cli/strategy/common.go Removed auto-commit references and removed checkCanRewind; updated metadata-branch commit message text.
cmd/entire/cli/strategy/clean_test.go Updated orphan/session-state test comment to remove auto-commit reference.
cmd/entire/cli/strategy/auto_commit_test.go Deleted auto-commit unit test suite.
cmd/entire/cli/strategy/auto_commit.go Deleted auto-commit strategy implementation.
cmd/entire/cli/status_test.go Updated status tests to use manual-commit.
cmd/entire/cli/status.go Removed internal↔display strategy mapping usage in status formatting.
cmd/entire/cli/setup_test.go Updated enable/setup tests to use manual-commit.
cmd/entire/cli/setup.go Removed auto-commit from enable command help/completion and simplified strategy handling.
cmd/entire/cli/settings/settings_test.go Updated settings tests to reflect auto-commit → manual-commit migration.
cmd/entire/cli/settings/settings.go Added migration logic + warning output for deprecated auto-commit strategy.
cmd/entire/cli/resume_test.go Removed auto-commit-specific resume test; updated metadata JSON strategy field.
cmd/entire/cli/reset_test.go Removed reset test for auto-commit strategy.
cmd/entire/cli/reset.go Removed auto-commit guidance from reset command help text.
cmd/entire/cli/paths/paths.go Updated metadata branch comment (now manual-commit only).
cmd/entire/cli/lifecycle.go Removed auto-commit transcript-position tracking logic.
cmd/entire/cli/integration_test/worktree_test.go Switched strategy under test to manual-commit.
cmd/entire/cli/integration_test/testenv_test.go Updated expected strategies count/list after removing auto-commit.
cmd/entire/cli/integration_test/testenv.go Removed auto-commit from AllStrategies() and adjusted comments.
cmd/entire/cli/integration_test/subagent_checkpoints_test.go Simplified checkpoint storage verification (manual-commit only).
cmd/entire/cli/integration_test/rewind_test.go Removed auto-commit-only multi-session rewind test.
cmd/entire/cli/integration_test/resume_test.go Switched resume integration tests to manual-commit strategy.
cmd/entire/cli/integration_test/hooks_test.go Removed auto-commit branch-commit assertions; manual-commit-only expectations.
cmd/entire/cli/integration_test/auto_commit_checkpoint_fix_test.go Deleted auto-commit integration regression tests.
cmd/entire/cli/explain_test.go Updated test fixtures to use manual-commit strategy string.
cmd/entire/cli/e2e_test/scenario_checkpoint_test.go Removed auto-commit e2e scenario.
cmd/entire/cli/debug.go Removed auto-commit debug subcommand implementation.
cmd/entire/cli/config_test.go Updated config loading tests to manual-commit + migration expectations.
cmd/entire/cli/clean.go Removed auto-commit-specific orphaning description.
cmd/entire/cli/checkpoint/checkpoint.go Generalized task checkpoint comment (no longer auto-commit-specific).
README.md Removed auto-commit from enable flag docs and troubleshooting guidance.
GEMINI.md Removed auto-commit from strategy documentation and key file list.
CLAUDE.md Removed auto-commit from strategy docs and clarified checkpoint ID flow.
.github/ISSUE_TEMPLATE/bug_report.yml Removed auto-commit as a selectable strategy option.
.claude/skills/test-repo/test-harness.sh Removed auto-commit-specific note for missing shadow branch.
.claude/skills/test-repo/SKILL.md Removed auto-commit/dual from strategy descriptions and expected-results matrix.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 5 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

@gtrrz-victor gtrrz-victor force-pushed the remove-auto-commit branch 2 times, most recently from 0f87401 to a7a1fdf Compare February 19, 2026 00:30
Entire-Checkpoint: 9257c9f8b2a3
Entire-Checkpoint: 3786a4d9fefd
Entire-Checkpoint: 68f26bfdf530
@gtrrz-victor gtrrz-victor marked this pull request as ready for review February 19, 2026 02:27
@gtrrz-victor gtrrz-victor requested a review from a team as a code owner February 19, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments