Skip to content

skip version checks on prerelease versions #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gtrrz-victor wants to merge 2 commits into
base: main
Choose a base branch
from
Open

skip version checks on prerelease versions #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77ac289
ignore git describe suffix for dev builds when comparing versions
Soph Feb 17, 2026
98f41bb
skip version checks on prerelease versions
gtrrz-victor Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cmd/entire/cli/versioncheck/versioncheck.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,12 @@ func isOutdated(current, latest string) bool {
latest = "v" + latest
}

// Skip notification for prerelease versions (development builds).
// We don't publish prerelease versions, so these are development builds and shouldn't trigger update notifications.
if semver.Prerelease(current) != "" {
return false
}

// semver.Compare returns -1 if current < latest
return semver.Compare(current, latest) < 0
}
Expand Down
9 changes: 8 additions & 1 deletion cmd/entire/cli/versioncheck/versioncheck_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,15 @@ func TestIsOutdated(t *testing.T) {
{"1.0.0", "v1.0.1", true, "mixed v prefix reversed"},

// Pre-release versions (semver uses hyphen)
{"1.0.0-rc1", "1.0.0", true, "prerelease in current"},
{"1.0.0-rc1", "1.0.0", false, "prerelease in current"},
{"1.0.0", "1.0.1-rc1", true, "prerelease in latest is still newer"},

// Git describe format (should strip suffix before comparing)
{"v0.4.4-76-g230b49bf-dirty", "v0.4.4", false, "git describe dirty build is not outdated"},
{"v0.4.4-76-g230b49bf", "v0.4.4", false, "git describe build is not outdated"},
{"v0.4.4-76-g230b49bf-dirty", "v0.4.5", false, "git describe build is not outdated"},
{"v0.4.4-1-gabcdef0", "v0.4.4", false, "git describe 1 commit ahead and is not outdated"},
{"v1.0.0-100-g1234567890ab-dirty", "v1.0.0", false, "git describe long hash dirty"},
}

for _, tt := range tests {
Expand Down