feat: add trail review CLI#1266
Open
dipree wants to merge 9 commits into
Open
Conversation
Entire-Checkpoint: 0fd32e9ceae9
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a68b07b. Configure here.
Entire-Checkpoint: 012879bddbd5
Entire-Checkpoint: 58d44d708365
Entire-Checkpoint: 1d403658033b
# Conflicts: # cmd/entire/cli/checkpoint/committed_reader_resolve.go # cmd/entire/cli/strategy/manual_commit.go
- Remove duplicate optionalStringValue helper; use stringPtrValue - Inline pointless runTrailWatchWithOptions wrapper into runTrailWatch - Add t.Parallel() to pure-function trail finding tests - Guard .git path check with EqualFold for case-insensitive filesystems - Document why the apply tests use bare git init over testutil.InitRepo Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 138a8d212cff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/425
Summary
entire trail findingfor agent-native findings: dashboard, list/detail, create, status updates, patch apply, and SSE watch.425,trl_abc123, orfeat/my-branch).entire trail list --status anyfor discovery; this PR improves that output withNUMandTITLEcolumns.POST /api/v1/trails/{trail_id}/reviews/commentsso agents do not need a review id.e2e/examples/trail-finding-golden-path.sh.Golden path
Making a code suggestion
Attach a unified diff when creating the finding:
--patch-file -reads the diff from stdin.--patchis also available for inline diffs. Users can later run:Output examples
entire trail list --status anyentire trail findingNo current-branch trail fallback
entire trail finding listentire trail finding addentire trail finding show <finding-id>entire trail finding apply <finding-id>With
--check:With
--resolve:Status commands
entire trail finding watchAPI shape added for finding creation
{ "client_id": "agent-run-123:finding-7", "title": "Missing expiry skew handling", "body": "Token refresh should allow clock skew before treating the session as expired.", "severity": "high", "confidence": 0.94, "location": { "granularity": "line", "file_path": "src/auth/session.ts", "start_line": 88 }, "suggested_changes": [ { "change_type": "unified_diff", "patch": "diff --git a/src/auth/session.ts b/src/auth/session.ts\n..." } ] }Tests
env -u PI_CODING_AGENT mise exec -- go test ./cmd/entire/cli ./cmd/entire/cli/apienv -u PI_CODING_AGENT mise exec -- go test ./...mise exec -- golangci-lint rungit diff --checkManual e2e example was added but not run automatically because it hits real services.