Improve the maintainability and clarity of some tests. #890
+34
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e library-specific.
This commit enhances tests using WMI. It ensures that `ISWbemProperty.Value` behaves correctly as a property with an `[out] POINTER(VARIANT)` parameter by: - Retrieving type information using `GetTypeInfo` and `GetRefTypeInfo`. - Inspecting `wParamFlags` to confirm `PARAMFLAG_FOUT | PARAMFLAG_FRETVAL`. - Validating the `vt` of the parameter as `VT_PTR` to `VT_VARIANT`.
Rename `Test` class to `TestWMI` for better clarity. Replace direct attribute access of `WbemScripting.wbemPrivilegeCreateToken` with `hasattr` check to enhance test robustness. Remove redundant `prop.Value` access as it is already assigned to `result`.
The test file `test_msi.py` has been renamed to `test_puredispatch.py` to better reflect its content and purpose.
Move the test skipping logic from module-level `setUpModule` to individual `ut.skip` decorators for test methods.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #890 +/- ##
==========================================
+ Coverage 85.02% 85.04% +0.01%
==========================================
Files 126 126
Lines 11716 11726 +10
==========================================
+ Hits 9962 9972 +10
Misses 1754 1754 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that naming tests after specific COM libraries, like the old
test_ie.py, makes them brittle.When a COM library becomes unavailable, the test breaks, and its original purpose can be lost.
To address this, I have renamed test files to reflect their testing goals rather than the specific libraries they use.
This will help future maintainers understand the test's intent and find alternative libraries if needed.
comtypes/test/test_msi.pyis renamed tocomtypes/test/test_puredispatch.py.comtypes/test/test_wmi.pyis renamed tocomtypes/test/test_variant_outparam.py.Additionally, I encountered an issue in
comtypes/test/test_eventinterface.pywhere the entire module was being skipped bysetUpModule.To make it easier to add new tests for event interfaces (outgoing interfaces), I have replaced the module-level skip with individual
@unittest.skipdecorators on the test methods.