perf(entgql): avoid COUNT(*) for pageInfo-only connection queries#625
Open
tutranngoc wants to merge 1 commit intoent:masterfrom
Open
perf(entgql): avoid COUNT(*) for pageInfo-only connection queries#625tutranngoc wants to merge 1 commit intoent:masterfrom
tutranngoc wants to merge 1 commit intoent:masterfrom
Conversation
Author
Collaborator
|
@tutranngoc fyi, you can use entcache package to cache query result of count(). So it wont hit database twice. |
Author
@giautm Thank you for sharing, however, my preference is to eliminate the need for a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description: Avoid unnecessary COUNT(*) query when resolving pageInfo
When querying a connection with
pageInfo, we always execute an extra SQL query (SELECT COUNT(*)). This is not required for computing pageInfo and adds avoidable datThe
build()call in:already computes cursor fields (
startCursor,endCursor) and correctly determines pagination flags (hasNextPage,hasPreviousPage) based on the paging arguments and returned nodes.Currently we also derive flags using
TotalCount, which forces aCOUNT(*):This makes every request that includes
pageInfopay for aCOUNT(*), even when callers don’t requesttotalCountand we don’t actually need it.What this PR changes:
Why it matters
Example query affected: