feat: allow aggregate ordering of through table edges#547
Open
michaelcaulley wants to merge 1 commit intoent:masterfrom
Open
feat: allow aggregate ordering of through table edges#547michaelcaulley wants to merge 1 commit intoent:masterfrom
michaelcaulley wants to merge 1 commit intoent:masterfrom
Conversation
michaelcaulley
commented
Oct 3, 2023
142b18d to
92f352e
Compare
92f352e to
7517af4
Compare
Contributor
Author
|
Thanks for taking a look at this @giautm. I generated the code for the projects that I missed. |
Contributor
Author
|
@giautm anything I can help with to get this merged? |
giautm
approved these changes
Oct 19, 2023
Collaborator
giautm
left a comment
There was a problem hiding this comment.
LGTM, thank you for your contribution.
a8m
reviewed
Oct 20, 2023
7517af4 to
b056f45
Compare
b056f45 to
402de01
Compare
402de01 to
4feb049
Compare
4feb049 to
e9ec4bb
Compare
4aabfb9 to
4cefd73
Compare
4cefd73 to
c972521
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
entgql.OrderField()aggregates for edges that use a Through table.would require the OrderField string to start with
FRIENDS_For the count aggregation the full string would be
FRIENDS_COUNT.