Page Components: fix drag-and-drop placement into and out of layout regions #10672#10673
Merged
Conversation
…egions #10672 Wired PageComponentsView to the SortableList projection API via projectTreeDrop. Mapped flattened tree nodes to drop nodes and committed moves with requestComponentMove. Replaced resolveTargetPath and the isDropAllowed prop; reused hasLayoutAncestor to block layout-in-layout. Exported calcSpacerWidth so the dragged row re-indents to its projected level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes drag-and-drop placement in the Page Components tree: dropping into a region now lands at the pointed position (not the end), an empty layout region can be entered from either direction, and dragging an item out to the parent level is reliable. The dragged row re-indents to show the level it will land at.
PageComponentsViewto theSortableListprojection API: maps the flattened tree to drop nodes, resolves the target withprojectTreeDrop, and commits viarequestComponentMove.resolveTargetPathheuristic and theisDropAllowedprop; reuseshasLayoutAncestorto block layout-in-layout drops.calcSpacerWidthfromPageComponentsItemand appliescontext.projectedIndentso the dragged row re-indents to its projected level.DetachedPageComponentsViewis unchanged.Requires enonic/lib-admin-ui#4513.
Closes #10672
Drafted with AI assistance