Fix maybe undefined variable offsets#23
Open
Mike-Hermans wants to merge 3 commits intoenjoping:masterfrom
Open
Fix maybe undefined variable offsets#23Mike-Hermans wants to merge 3 commits intoenjoping:masterfrom
Mike-Hermans wants to merge 3 commits intoenjoping:masterfrom
Conversation
Mike-Hermans
changed the title
atimmer
requested changes
Jan 10, 2023
Collaborator
atimmer
left a comment
atimmer
left a comment
There was a problem hiding this comment.
In general a good change, but I’m seeing a lot of places where the values aren’t necessarily optional. For example, for lines I would assume the start (and maybe the end) coordinates would be mandatory.
Are you running into issues with malformed dxf files?
| $thickness = $data[39] ? $data[39] : 0; | ||
| $text = new Text($data[1], $point, $data[40], $rotation, $thickness); | ||
| if ($data[72]) { | ||
| $point = [$data[10] ?? 0, $data[20] ?? 0, $data[30] ?? 0]; |
Collaborator
There was a problem hiding this comment.
I don’t know about TEXT, but are these values optional for those entities?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates all $data[] checks to return 0 (or any other value if it was defined) for the
addReadEntitymethod.Should fix #18