You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 11, 2025. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure canaryLatest() and the default return in canarySpec() align; after adding case 1023 the default now also returns v1023. Confirm this matches intended rollout so older/unknown versions correctly resolve.
The script assumes HTTPS endpoint works for former WSS by sed replacement; verify all RPC endpoints support HTTPS JSON-RPC and CORS. Consider retry/backoff and clearer error messages per network to avoid silent failures in automation.
The numeric sort in update_exports may misorder non-numeric filenames or leading zeros; validate it preserves intended alphabetical/numeric order across all exports.
Preserve hostnames and paths when converting wss to https. The current sed only swaps the scheme and may break URLs missing // handling; use a more precise substitution to avoid malformed URLs.
Why: The improvement makes the scheme substitution precise (wss:// to https://), reducing risk of malformed URLs. It’s accurate and has meaningful reliability impact.
Medium
Enforce integer specVersion type
Validate specVersion type to avoid unexpected matches (e.g., strings). Explicitly type it as int to prevent runtime issues in the switch.
-String canarySpec(specVersion) {+String canarySpec(int specVersion) {
switch (specVersion) {
case 1000:
return c.v1000;
...
case 1022:
return c.v1022;
case 1023:
return c.v1023;
default:
return canaryLatest();
}
}
Suggestion importance[1-10]: 7
__
Why: Typing specVersion as int is a reasonable, accurate improvement that prevents mismatches in the switch. It’s a maintainability/type-safety enhancement, not critical.
Medium
General
Guard against stale latest version
Ensure canaryLatest() always returns the highest exported version. If a newer version (e.g., v1024) exists, this hardcoded return will become stale and incorrect.
String canaryLatest() {
- return c.v1023;+ return c.v1023; // Update this when adding a higher canary spec export.
}
Suggestion importance[1-10]: 4
__
Why: The note is valid but minimal; it doesn't change behavior and just warns to keep canaryLatest() updated. Impact is low and it's already correct in the PR.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
PR Type
Enhancement, Other
Description
Add matrix canary metadata v1023
Update canaryLatest and switch mapping
Alphabetize/normalize export orders
Add fetch_metadata automation script
Diagram Walkthrough
File Walkthrough
6 files
Reorder and add enjin canary exportsAdd v1023 and reorder matrix canary exportsPoint canaryLatest to v1023; map 1023Reorder and add enjin production exportsAdd/reorder matrix production exportsIntroduce matrix canary metadata v1023 constant1 files
Add metadata fetch and export update script