Skip to content

fix NaN 0 bug in decomp serice, made trig rigorous in latex gen#26

Closed
CaptainChicky wants to merge 1 commit intoenjeck:mainfrom
CaptainChicky:main
Closed

fix NaN 0 bug in decomp serice, made trig rigorous in latex gen#26
CaptainChicky wants to merge 1 commit intoenjeck:mainfrom
CaptainChicky:main

Conversation

@CaptainChicky
Copy link
Copy Markdown

Hey, nice refactor!

Anyway here are the same 2 bugs from 2023 that still need fixing 🥀
i beg, please fix these they are actually bugging me so much @enjeck

  1. 0 decomposition results in nan and undefined: NaN appearing in expressions for integer zero #21 Fix issue #21 #22 this is fixed in decomposition service b y excluding 0
  2. cosine and sine are not rigorous 🥀💔 you are making an equation, not a computable expression, please fix this, you dont have to copy my limit values but at least add a limit that you like by editing my PR or something pls

i discarded my original PR #23 and had to go through all your new refactored code for this xd

@enjeck
Copy link
Copy Markdown
Owner

enjeck commented Jan 10, 2026

Thanks! It didn't work fully for me, and I couldn't push to your branch, so I incorporated your changes into 8dddcb7. Appreciate the help

@enjeck enjeck closed this Jan 10, 2026
@CaptainChicky
Copy link
Copy Markdown
Author

tysm 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants