bugfix: add option to disable extension on dashboard#156
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request provides users with greater control over the extension's behavior by allowing them to selectively disable it on the Kick dashboard. This enhancement addresses potential conflicts or performance concerns users might experience on that specific page, improving the overall user experience by offering a configurable opt-out. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a feature to disable the extension on the Kick dashboard, using a cookie to control its activation. The overall approach is sound. My review includes suggestions to make the cookie-checking logic more robust and to improve maintainability by centralizing the cookie name into a constant, preventing potential future bugs and making the code easier to manage.
There was a problem hiding this comment.
Pull request overview
Adds a Kick setting that lets users prevent the extension from starting on dashboard.kick.com, implemented via a cookie checked during KickPlatform.shouldStart() (so the decision can be made before async settings load).
Changes:
- Add new Kick setting
_disableExtensionOnDashboardand default it tofalse. - Add settings UI toggle and an event handler that sets/clears a
_enhancer_disable_dashboardcookie. - Update Kick startup gating to block additional subdomains and (optionally) the dashboard based on the cookie.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/types/platforms/kick/kick.settings.types.ts |
Adds a new Kick settings key for the dashboard-disable toggle. |
src/platforms/kick/modules/settings/settings.module.tsx |
Adds a new settings toggle plus an event handler that writes the dashboard-disable cookie. |
src/platforms/kick/kick.platform.ts |
Uses a hostname blocklist and conditionally blocks dashboard.kick.com based on the cookie. |
src/platforms/kick/kick.constants.ts |
Adds the new setting to Kick default settings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
temp fix