Issue #84 -- emit esl::end on socket::close #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
net.Socket emits "end" only on successful closing, but it emits "close" in error conditions as well.
Owner
|
If you rebase this branch to the latest, it should run CI so we can check if it passes. |
|
We think we are facing the same issue. The TCP connection was closed and the application does not receive any signal. |
Owner
|
A PR on the latest v1 branch with these changes that pass CI would allow me to merge it in. |
Author
|
come on, it's a one-liner patch, and you have the PR in two branches already |
Author
|
and this PR is actually against v1.x branch |
|
Hello @englercj, does it possible to merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net.Socket emits "end" only on successful closing, but it emits "close" in error conditions as well.