Skip to content

Conversation

@krasio
Copy link

@krasio krasio commented Feb 5, 2013

No description provided.

@krutten
Copy link
Contributor

krutten commented Mar 21, 2013

Hello Krasimir,

We reviewed this and need a minor changed added.

Change cookbooks/statsd-librato/recipes/default.rb:

template "/etc/monit.d/statsd.monitrc" do
    owner node[:owner_name]
    group node[:owner_name]
    mode 0644
    source "monitrc.conf.erb"
    variables({
       :user => node[:owner_name],
       :app_name => app_name
     })
  end

and cookbooks/statsd-librato/templates/default/monitrc.conf.erb

check process statsd
   with pidfile /data/<%= @app_name %>/shared/pids/statsd.pid
   start = "/data/<%= @app_name %>/shared/statsd start" as uid <%= @user %> and gid <%= @user %>
   stop = "/data/<%= @app_name %>/shared/statsd stop" as uid <%= @user %> and gid <%= @user %>
   group statsd

This protects against the case when a user has selected a different username for the environment. This was the only issue we saw in our review. Thank you for writing this and we look forward to merging it soon.

@krasio
Copy link
Author

krasio commented Apr 12, 2013

Hi,

Changes applied. Thanks for pointing this out to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants