Feat/wna server #35

azam-ismail · 2026-01-15T07:51:17Z

No description provided.

hejkerooo · 2026-01-15T07:58:54Z

src/routes/admin.ts

+
+const adminLogger = createLogger('Admin');
+
+export const createAdminRouter = (): express.Router => {


those endpoints can be called by smartflows, can we make separate http server for it? We need to consider additional security layer here so no one can randomly stop instance

hejkerooo · 2026-01-15T08:00:28Z

src/routes/admin.ts

+        });
+
+        // Perform graceful shutdown after response is sent
+        setTimeout(() => {


I really dislike this setTimeout. Can you send SIGTERM and add event handler on it?

hejkerooo · 2026-01-15T08:00:51Z

src/health/health.ts

  };
 };
+
+const getOperatorInfo = async (timeoutMs: number = 5000): Promise<OperatorInfo | undefined> => {


move it to different place and export as public method

hejkerooo · 2026-01-15T08:01:17Z

docs/env-vars.md

 | `LOCAL_SOLUTIONS_PATH`         | Path to locally hosted NodeRed solution flow files to be used when installing solutions using "local" prefix within WorkLogic field.                                                                  | `string`               |                                                          |
 | `SS58_FORMAT`                  | SS58 Key Format.                                                                                                                                                                                      | `number` (_>0_)        | `42`                                                     |
 | `PRETTY_PRINT`                 | Should pretty print logs. If you plan to use Grafana or any other log tooling it's recommended to set it to false.                                                                                    | `'true' \| 'false'`    | `'false'`                                                |
+| `LOG_FILE_PATH`                | Full path to log file (e.g., /var/log/app.log or ./logs/app.log)                                                                                                                                      | `string`               |                                                          |


If value is not provided it means that log file transport is disabled

hejkerooo · 2026-01-15T08:02:38Z

src/health/health.ts

  };
 };
+
+const getOperatorInfo = async (timeoutMs: number = 5000): Promise<OperatorInfo | undefined> => {


instead of undefined please use null, it's more explicit

hejkerooo · 2026-01-15T08:03:24Z

src/health/health.ts

+          return {
+            id: solution.solutionId,
+            name,
+            status: 'Active', // Assume active if installed


hejkerooo · 2026-01-15T08:03:41Z

src/health/health.ts

+      solutionGroups,
+    };
+  } catch {
+    return undefined;


at least print error so we know what is going on

hejkerooo · 2026-01-15T08:05:14Z

src/node-red/red.ts

+export const getAllInstalledSolutionsWithGroups = async (): Promise<InstalledSolutionDetails[]> => {
+  const tabNodes = await getTabNodes();
+
+  const solutions: Array<InstalledSolutionDetails | null> = await Promise.all(


why you need Promise.all ?

hejkerooo · 2026-01-15T08:06:07Z

src/util/logger.ts

+  return logPath;
+};
+
+const ensureLogDir = (logPath: string): void => {


ensureLogDirExists

hejkerooo · 2026-01-15T10:28:12Z

src/routes/admin.ts

@@ -0,0 +1,46 @@
+import express from 'express';
+import { createLogger } from '../util/logger';
+import { getIsShuttingDown } from '../shutdown';


Can you create a middleware that will not accept new requests?

It can be even applied to submit vote endpoint so we don't accept new votes in case

azam-ismail requested a review from kim-energyweb January 15, 2026 07:51

azam-ismail requested a review from hejkerooo as a code owner January 15, 2026 07:51

azam-ismail changed the base branch from master to feat/auth January 15, 2026 07:52

feat: enable file logger

902b1f6

azam-ismail force-pushed the feat/wna-server branch from 4d7c708 to 227e07b Compare January 15, 2026 08:42

azam-ismail added 2 commits January 15, 2026 17:43

feat: admin stop and shutdown endpoint

94ee983

feat: endpoint to get solution group details

37786f7

azam-ismail force-pushed the feat/wna-server branch from 227e07b to 37786f7 Compare January 15, 2026 09:43

hejkerooo reviewed Jan 16, 2026

View reviewed changes

fix: admin stop, health endpoint

cd79ed8

azam-ismail requested a review from hejkerooo January 19, 2026 07:18


		const adminLogger = createLogger('Admin');

		export const createAdminRouter = (): express.Router => {

Feat/wna server #35

Are you sure you want to change the base?

Feat/wna server #35

Uh oh!

Conversation

azam-ismail commented Jan 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants