Add a LoreQuest subclass of Quest#2283
Merged
Merged
Conversation
There are some properties that only make sense on LoreQuests, and we treat them differently in the game state. Rather than using `_validate_property` magic to hide those properties on quests that don't have the is_lore_quest property set, make a subclass, update all quest resources for lorequests to be LoreQuest instances instead, and adjust code that uses these LoreQuest-specific properties. Arguably the authors/affiliation properties of Quest only make sense for StoryQuests, so perhaps those should have a subclass, but that's one for another day.
manuq
approved these changes
Jun 3, 2026
Collaborator
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
Good idea, it makes sense.
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/add-a-lorequest-subclass-of-quest/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some properties that only make sense on LoreQuests, and we treat them differently in the game state.
Rather than using
_validate_propertymagic to hide those properties on quests that don't have the is_lore_quest property set, make a subclass, update all quest resources for lorequests to be LoreQuest instances instead, and adjust code that uses these LoreQuest-specific properties.Arguably the authors/affiliation properties of Quest only make sense for StoryQuests, so perhaps those should have a subclass, but that's one for another day.