Skip to content

Loom: Save after end-of-quest interaction#2276

Open
wjt wants to merge 1 commit into
mainfrom
wjt/loom-save-after-end-of-quest-interaction
Open

Loom: Save after end-of-quest interaction#2276
wjt wants to merge 1 commit into
mainfrom
wjt/loom-save-after-end-of-quest-interaction

Conversation

@wjt
Copy link
Copy Markdown
Member

@wjt wjt commented Jun 2, 2026

Previously the Eternal Loom implicitly saved the game state at the end
of the end-of-quest interaction, originally because GameState always
saved itself, and then, after the recent refactor, because it switched
to a Sokoban scene immediately which triggers a save.

Now we need to explicitly save the game state at the end of the
interaction, once the quest has been marked as complete.

In addition, the loom would check when instantiated whether the
end-of-quest interaction is possible, but it cached the result for the
lifetime of the instance. With the removal of the Sokoban transition
this no longer works. We can call is_item_offering_possible() directly
in the dialogue, and eliminate this code to change the dialogue title at
startup. While we're there, set the dialogue resource in the scene not
the script.

Previously the Eternal Loom implicitly saved the game state at the end
of the end-of-quest interaction, originally because GameState always
saved itself, and then, after the recent refactor, because it switched
to a Sokoban scene immediately which triggers a save.

Now we need to explicitly save the game state at the end of the
interaction, once the quest has been marked as complete.

In addition, the loom would check when instantiated whether the
end-of-quest interaction is possible, but it cached the result for the
lifetime of the instance. With the removal of the Sokoban transition
this no longer works. We can call is_item_offering_possible() directly
in the dialogue, and eliminate this code to change the dialogue title at
startup. While we're there, set the dialogue resource in the scene not
the script.
@wjt wjt requested a review from a team as a code owner June 2, 2026 19:29
@wjt wjt changed the title Loom: Save after end-of-quest interaction [1/1] Loom: Save after end-of-quest interaction Jun 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Play this branch at https://play.threadbare.game/branches/endlessm/wjt/loom-save-after-end-of-quest-interaction/.

(This launches the game from the start, not directly at the change(s) in this pull request.)

@wjt wjt changed the title [1/1] Loom: Save after end-of-quest interaction Loom: Save after end-of-quest interaction Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant