Camera utility function#2273
Merged
Merged
Conversation
The Phantom Camera addon doesn't have a way to keep the same limits as the active camera before switching. So this has to be done though scripting. Move the function in player_hook.gd into a utility script, and make it static.
Otherwise part of the scene outside the limits can be seen during the transition. Also: - Remove an unwanted comment - Add 1 second delay before displaying the dialogue again - Use sine transition for the tween resource of the PhantomCamera2D
wjt
approved these changes
Jun 2, 2026
|
Play this branch at https://play.threadbare.game/branches/endlessm/camera-utility-function/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grappling_hook_needles: Copy camera limits before the animation
Otherwise part of the scene outside the limits can be seen during the
transition. Also:
Add utility script for camera
The Phantom Camera addon doesn't have a way to keep the same limits as the
active camera before switching. So this has to be done though scripting.
Move the function in player_hook.gd into a utility script, and make it static.