Phantom Camera: Reduce unnecessary processing#2271
Merged
Conversation
Apply the changes I have submitted upstream in ramokz/phantom-camera#657 to avoid processing every frame in the editor, even when the open scene does not use PhantomCamera. As detailed in that PR and in ramokz/phantom-camera#649, I haven't figured out how to avoid the PhantomCameraHost node processing every frame even when the viewfinder is closed. And as also detailed there: any inactive PhantomCamera2D still _process()es every frame, and the PlayerHook has an inactive PhantomCamera2D, so... However in most scenes containing the player we have at least one moving tree or water ripple animation, which causes the scene to render at 60fps anyway. So, oh well!
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/phantom-camera-reduce-unnecessary-processing/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
Jun 2, 2026
Collaborator
Could this be because of the "Always" default in inactive update mode? 
|
Member
Author
Yes. However if you disable that, switching to this camera is janky in-game, because its position is not updated until the moment it is activated. Sorry, I forgot to write that in this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phantom Camera: Reduce unnecessary processing
Apply the changes I have submitted upstream in
ramokz/phantom-camera#657 to avoid processing
every frame in the editor, even when the open scene does not use
PhantomCamera.
As detailed in that PR and in
ramokz/phantom-camera#649, I haven't figured
out how to avoid the PhantomCameraHost node processing every frame even
when the viewfinder is closed.
And as also detailed there: any inactive PhantomCamera2D still
_process()es every frame, and the PlayerHook has an inactive
PhantomCamera2D, so...
However in most scenes containing the player we have at least one moving
tree or water ripple animation, which causes the scene to render at
60fps anyway. So, oh well!