Skip to content

music puzzle: Only reveal thread when you talk to musician #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manuq merged 1 commit into from
Jun 2, 2026
Merged

music puzzle: Only reveal thread when you talk to musician #2267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scenes/quests/lore_quests/quest_001/1_music_puzzle/components/dialogues/musician.dialogue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# SPDX-FileCopyrightText: The Threadbare Authors
# SPDX-License-Identifier: MPL-2.0
~ start
if thread.revealed:
=> collect_the_thread

if puzzle.is_solved():
=> item_hint

Expand Down Expand Up @@ -88,6 +91,8 @@ match get_hint_level()
Musician: You did it!... That's the magical melody... how wonderful. It's been so long since I heard it.
Musician: You have opened the portal to the Ink Well. Let's go there to collect ink so songs and stories can be written again.
Musician: But we must be careful, InkDrinkers dwell there!
do thread.reveal()
~ collect_the_thread
Musician: The melody awakened the memory of song. Collect the Memory threads before you go!
=> END

Expand Down
1 change: 1 addition & 0 deletions scenes/quests/lore_quests/quest_001/1_music_puzzle/components/music_puzzle.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
extends Node2D

@onready var background_music: BackgroundMusic = %BackgroundMusic
@onready var thread: CollectibleItem = %CollectibleItem


func _on_sequence_puzzle_step_solved(step_index: int) -> void:
Expand Down
2 changes: 1 addition & 1 deletion scenes/quests/lore_quests/quest_001/1_music_puzzle/music_puzzle.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1476,6 +1476,7 @@ sequence = [NodePath("../../Rocks/C"), NodePath("../../Rocks/Bb"), NodePath("../
hint_sign = NodePath("../../Bonfires/BonfireSign4")

[node name="CollectibleItem" parent="OnTheGround/SequencePuzzle" unique_id=530712613 instance=ExtResource("14_src2c")]
unique_name_in_owner = true
position = Vector2(-726, 43)
revealed = false
item = SubResource("Resource_dp3eg")
Expand Down Expand Up @@ -1570,5 +1571,4 @@ script = ExtResource("45_ps6xw")
stream = ExtResource("47_orlow")
metadata/_custom_type_script = "uid://c8405c212rbn6"

[connection signal="solved" from="OnTheGround/SequencePuzzle" to="OnTheGround/SequencePuzzle/CollectibleItem" method="reveal"]
[connection signal="step_solved" from="OnTheGround/SequencePuzzle" to="." method="_on_sequence_puzzle_step_solved"]