feat: smarter subtask completion with user verification#2
Open
jcbmrrs wants to merge 1 commit into
Open
Conversation
- done: only auto-check bullets with an explicitly related passing test; interview user for all others (one question per unchecked bullet) - done: block DONE status if any subtask remains unchecked — task stays IN PROGRESS in Active Work until all bullets are [x] - done: move ### section to ## Completed only when fully complete; never move a section with open [ ] bullets - done: update **Status** line to reflect outcome (✅ DONE or IN PROGRESS) with today's date in both cases - done: distinguish completion report (✅ Task Complete) from partial progress report (🔄 Progress Saved) with incomplete subtask list - next: update **Status**: line to IN PROGRESS (date) when starting a task Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current
/doneskill marks all unchecked subtask bullets as[x]unconditionally when completing a task. This PR replaces that with a verification-driven approach where completion is earned, not assumed.Changes
skills/done/SKILL.md- [ ]bullet remains after verification, the task is NOT marked done — it keeps its IN PROGRESS status, stays in## Active Work, and commits aswip(TASK-XXX):with a progress report listing what's left## Completedis a guarantee: a task only moves to## Completedwhen every subtask bullet is[x]. No section with open bullets can land there**Status**:line is always updated with today's date, reflecting either✅ DONEorIN PROGRESSdepending on outcome✅ Task Completevs🔄 Progress Saved — Task Still In Progress, with the latter listing incomplete subtasks and prompting a follow-up via/master-plan:nextskills/next/SKILL.md**Status**:line toIN PROGRESS (YYYY-MM-DD)so the date of last activity is always recordedMotivation
The previous behavior silently marked work done regardless of whether it was. This made
## Completeduntrustworthy and lost track of partially finished tasks. With these changes, the MASTER_PLAN.md becomes an accurate record: IN PROGRESS means there's real work left, DONE means it's actually done.🤖 Generated with Claude Code