Fix platform-dependent newline in WordDocumentReader test assertion #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Co-authored-by: HowardvanRooijen <128664+HowardvanRooijen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update PR #7 based on review comments
Fix platform-dependent newline in WordDocumentReader test assertion
Jan 29, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates a test assertion in the WordDocumentReader tests to use Environment.NewLine instead of a hardcoded \n for improved platform compatibility.
Changes:
- Updated test assertion at line 104 to use
Environment.NewLineinstead of hardcoded\n - Updated corresponding comment to reflect the change
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HowardvanRooijen
added a commit
that referenced
this pull request
Jan 30, 2026
* Enhance WordDocumentReader to preserve semantic structure - Modified `WordDocumentReader` to detect "Heading1" through "Heading6" styles and prepend Markdown-style headers (`#` to `######`) to the text. - Added code comments explaining the heading detection logic. - Removed unused `HeaderRegex` from `SemanticChunker`. - Added `WordDocumentReaderTests` to verify that document structure is preserved. Fixes #6 * Add tests for WordDocumentReader to verify heading preservation in complex documents * Fix platform-dependent newline in WordDocumentReader test assertion (#8) * Initial plan * Fix platform-dependent newline assertion in WordDocumentReaderTests Co-authored-by: HowardvanRooijen <128664+HowardvanRooijen@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: HowardvanRooijen <128664+HowardvanRooijen@users.noreply.github.com> * Add comprehensive tests for WordDocumentReader functionality and metadata extraction --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: HowardvanRooijen <128664+HowardvanRooijen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test assertion in
WordDocumentReaderTests.ReadAsync_ComplexDocument_PreservesStructureCorrectlyhardcoded a Unix newline (\n), but the implementation usesStringBuilder.AppendLine()which emitsEnvironment.NewLine(\r\non Windows,\non Unix).Changes:
Environment.NewLineinstead of hardcoded\n💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.