Item descriptions and more compact match history#85
Open
DrInfiniteExplorer wants to merge 1 commit intoencratite:masterfrom
DrInfiniteExplorer:master
Open
Item descriptions and more compact match history#85DrInfiniteExplorer wants to merge 1 commit intoencratite:masterfrom DrInfiniteExplorer:master
DrInfiniteExplorer wants to merge 1 commit intoencratite:masterfrom
DrInfiniteExplorer:master
Conversation
Made rendering of match history more horizontally compact, as on some screens the table stretches very wide. Also added item description popups in match history. Removed the min-width property from #summonerGamesContainer to make it possible to render the table on smaller screens without horizontal scrolling. Added class for identifying table headers for headers in the summonerGames-table in the match-history. Added css to make sure that the 'items' and 'date' collumns do not introduce awkward linebreaks. Reduced padding on '#summonerGames th' and '#summonerGames td'. Turned the item-<img>'s into <div><img><ul>...</ul></div> to enable item-descriptions on the match-history page. Added css-rules for 'table.statistics ul.itemDesc', 'table.statistics .item' and 'table.statistics item:hover .itemDesc' to handle the actual popups. Added margin-bottom to #summonerGames to prevent page from re-layouting when displaying vertically long item descriptions (result from the page becomming less wide with introduction of horizontal scroll bar).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made rendering of match history more horizontally compact, as on some
screens the table stretches very wide.
Also added item description popups in match history.
Removed the min-width property from #summonerGamesContainer to make it
possible to render the table on smaller screens without horizontal
scrolling.
Added class for identifying table headers for headers in the
summonerGames-table in the match-history.
Added css to make sure that the 'items' and 'date' collumns do not
introduce awkward linebreaks.
Reduced padding on '#summonerGames th' and '#summonerGames td'.
Turned the item-![]()
's into
...
item-descriptions on the match-history page. Added css-rules for
'table.statistics ul.itemDesc', 'table.statistics .item' and
'table.statistics item:hover .itemDesc' to handle the actual popups.
Added margin-bottom to #summonerGames to prevent page from re-layouting
when displaying vertically long item descriptions (result from the page
becomming less wide with introduction of horizontal scroll bar).