Open
Conversation
This is preferred as crt0stack::Reader::from_environ() relies on the global environ pointer and: 1. The environ pointer is not guaranteed to point to memory before auxv by any standard I am aware of. It just happens to do so in some C library implementations if the environment has not been modified. 2. The environ pointer is definitely not going to point to memory before auxv after calling any environment modifying function such as setenv(3). Calling getauxval(3) is the only standards compliant way of accessing values in the auxiliary vector. Co-authored-by: Patrick Oppenlander <patrick.oppenlander@gmail.com> Signed-off-by: Richard Zak <richard.j.zak@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is preferred as crt0stack::Reader::from_environ() relies on the global environ pointer and:
Calling getauxval(3) is the only standards compliant way of accessing values in the auxiliary vector.
Dup of #20 since it has conflicts and tests weren't running.