Conversation
MMesch
commented
Mar 11, 2026
MMesch
commented
- adds back test and dist folders
- adds astropy tests
|
This is related to #5088 and calling parts of the original astropy test suite. I am unsure whether this is a good approach and thus curious to hear opinions. |
| - '**/*.pyx' | ||
| - '**/__pycache__/**' | ||
| - '**/*.pyc' | ||
| - '**/test_*.py' |
There was a problem hiding this comment.
Although I do agree running the full test suite may be a good idea, I'd love for us to not ship the test suite as part of the package.
The filtering here reduced the package size from 9.12MB to 2.5MB for astropy (when it was not a metapackage)
There was a problem hiding this comment.
It might be possible to specify the test-suite as being extra assets for the test run, without shipping the tests in the package itself
There was a problem hiding this comment.
I agree that this would be the best approach. I just don't know how to do it with emscripten forge. Do you have an example somewhere?
There was a problem hiding this comment.
I'm not sure exactly, but the tests entry has a files: entry where we could list the files needed for testing?
There was a problem hiding this comment.
Any way to distinguish between build/testing and what gets actually shipped?
2 participants
