feat (media-library): emscli media library update file links#1572
Merged
Davidmattei merged 32 commits intoems-project:7.xfrom Mar 25, 2026
Merged
Conversation
added 4 commits
February 4, 2026 16:50
…g fields) into ems object links (if the file exists in a media library)
…-library-update-file-links
theus77
changed the title
added 9 commits
February 6, 2026 10:52
…tion. Removed lines.
theus77
reviewed
Feb 9, 2026
Comment on lines
+14
to
+15
| use RectorPrefix202601\Symfony\Component\Console\Input\InputArgument; | ||
| use RectorPrefix202601\Symfony\Component\Console\Input\InputOption; |
Comment on lines
+59
to
+76
| $this->options = new MediaLibrarySyncOptions( | ||
| //TODO If I have to put all args in this method, do I have to declare them before (in the object attributes) or can I simply put a bunch of nulls and false? | ||
| folder: $this->getArgumentString(self::ARGUMENT_FOLDER), | ||
| contentType: $this->getOptionString(self::OPTION_CONTENT_TYPE), | ||
| folderField: $this->getOptionString(self::OPTION_FOLDER_FIELD), | ||
| pathField: null, | ||
| fileField: null, | ||
| metaDataFile: null, | ||
| locateRowExpression: null, | ||
| targetFolder: null, | ||
| dryRun: false, | ||
| onlyMissingFile: false, | ||
| onlyMetadataFile: false, | ||
| hashFolder: false, | ||
| hashMetaDataFile: false, | ||
| ); | ||
|
|
||
| } |
Member
There was a problem hiding this comment.
Why do you want to have a MediaLibrarySyncOptions? With all those options? I would recommand to first starts with simple class's members
| foreach ($coreApi->search()->scroll($search) as $hit) | ||
| { | ||
|
|
||
| foreach($this->fields as $field) { |
Member
There was a problem hiding this comment.
Do not hesitate to create functions in order to avoid too much nested loops
theus77
reviewed
Feb 10, 2026
Comment on lines
+82
to
+83
| $this->io->section('Found Media Library files'); | ||
| dump($this->logReports); |
Member
There was a problem hiding this comment.
See in the colibri script how an excel is generated and uploaded in the admin
Comment on lines
+113
to
+115
| if($match['content_type'] === 'media_file') { | ||
| $emsLink = EMSLink::fromMatch($match); | ||
| $this->logMediaLibraryLink($key, $emsLink, $value); |
Member
There was a problem hiding this comment.
No need to log already "good" links
theus77
reviewed
Feb 13, 2026
| ], $tempFile->path); | ||
| $filename = \sprintf('UpdateFileLinks - Rapport %s.xlsx', \date('YmdHis')); | ||
| $hash = $this->coreApi->file()->uploadFile($tempFile->path, 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet', $filename); | ||
| $this->io->success($this->buildUrl($hash, 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet', $filename)); |
Member
There was a problem hiding this comment.
Does the mime type not already define somewhere ?
Contributor
Author
There was a problem hiding this comment.
No but it can be put in a const to avoid repetition
theus77
reviewed
Mar 14, 2026
| $this->mediaLibraryContentType = $this->getOptionString(self::OPTION_MEDIA_LIBRARY_CONTENT_TYPE); | ||
| $this->fileField = $this->getOptionString(self::OPTION_FILE_FIELD); | ||
| $this->coreApi = $this->adminHelper->getCoreApi(); | ||
| $this->mimeType = $this->getOptionString(self::OPTION_MIME_TYPE); |
Member
There was a problem hiding this comment.
Not really useful to me. The mimetype 'Type of spreadsheet document', 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet' should be defined in the class EMS\Helpers\Html\MimeTypes
| $defaultAlias = $this->coreApi->meta()->getDefaultContentTypeEnvironmentAlias($this->contentTypeName); | ||
| $search = new Search([$defaultAlias]); | ||
| $search->setContentTypes([$this->contentTypeName]); | ||
| $search->setSources(['*']); |
Member
There was a problem hiding this comment.
Use $this->fields instead of retriving everything
Member
There was a problem hiding this comment.
Think about converting property accessor field to a elasticsearch field
| if ($found && $this->force) { | ||
| $value = \str_replace($match[0], $found->jsonSerialize(), $value); | ||
| } else { | ||
| $this->logAssetLink($key, EMSLink::fromMatch($match), $value); |
Member
There was a problem hiding this comment.
What do you log? not found or not $this->force
|
|
||
| private function findMediaFileByHash(EMSLink $link, string $hash, mixed $value): ?EMSLink | ||
| { | ||
| $alias = $this->coreApi->meta()->getDefaultContentTypeEnvironmentAlias($this->mediaLibraryContentType); |
The following changes were applied : - Rename several variables for better clarity - Improve log handling when replacing asset links - Narrow the search scope of `setSources` - Move `mediaLibraryContentTypeEnvironmentAlias` declaration to initialization
YanisGroffier
force-pushed
the
feat/emscli-media-library-update-file-links
branch
from
35f5a9b to
80a6818
Compare
theus77
reviewed
Mar 24, 2026
Comment on lines
+177
to
+183
| if ($found) { | ||
| $status = 'Asset link found but not replaced.'; | ||
| if ($this->force) { | ||
| $value = \str_replace($match[0], $found->jsonSerialize(), $value); | ||
| $status = 'Existing asset link successfully replaced.'; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if ($found) { | |
| $status = 'Asset link found but not replaced.'; | |
| if ($this->force) { | |
| $value = \str_replace($match[0], $found->jsonSerialize(), $value); | |
| $status = 'Existing asset link successfully replaced.'; | |
| } | |
| } | |
| if ($found && $this->force) { | |
| $value = \str_replace($match[0], $found->jsonSerialize(), $value); | |
| $status = 'Existing asset link successfully replaced.'; | |
| } elseif ($found) { | |
| $status = 'Asset link found but not replaced.'; | |
| } |
| $link = EMSLink::fromMatch($match); | ||
| $hash = $link->getOuuid(); | ||
| $found = $this->findMediaFileByHash($link, $hash, $value); | ||
| $status = 'No Media Library object link found.'; |
Member
There was a problem hiding this comment.
Maybe add the file name or the hash in the message
| $found = $this->findMediaFileByHash($link, $hash, $value); | ||
| $status = 'No Media Library object link found.'; | ||
| if ($found) { | ||
| $status = 'Asset link found but not replaced.'; |
Member
There was a problem hiding this comment.
Suggested change
| $status = 'Asset link found but not replaced.'; | |
| $status = \sprintf('Asset link found but not replaced for %s.', $emsLink->getOuuid()); |
added 2 commits
March 24, 2026 12:01
theus77
approved these changes
Mar 24, 2026
theus77
approved these changes
Mar 24, 2026
Member
|
@Davidmattei Can you review and merge in this PR? |
Member
7.1 or 7.x ? The plan is to retag 7.1 somewhere next week |
Davidmattei
requested changes
Mar 24, 2026
Member
7.x is ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command to convert ems file links (in wysiwyg fields) into ems object links (if the file already exists in a media library)