Skip to content

Avoid warning when it is a test #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jmzp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid warning when it is a test #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/bcrypt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,16 @@ var randomFallback = null;
* Generates cryptographically secure random bytes.
* @function
* @param {number} len Bytes length
* @param {boolean} testParam To avoid the warning if it is a test
* @returns {!Array.<number>} Random bytes
* @throws {Error} If no random implementation is available
* @inner
*/
function random(len) {
function random(len, testParam) {
/* fallback */
var test = testParam || false;
if (!randomFallback) {
console.warn("Using Math.random is not cryptographically secure! Use bcrypt.setRandomFallback to set a PRNG.");
if (!test) console.warn("Using Math.random is not cryptographically secure! Use bcrypt.setRandomFallback to set a PRNG.");
var buf = new Uint8Array(len);
return buf.map((item) => Math.floor(Math.random() * (256 - 1 + 1) + 1));
}
Expand All @@ -32,7 +34,7 @@ function random(len) {
// Test if any secure randomness source is available
var randomAvailable = false;
try {
random(1);
random(1, true);
randomAvailable = true;
} catch (e) {}

Expand Down