Skip to content

seq: optimize append #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sorawee wants to merge 1 commit into
base: master
Choose a base branch
from
Open

seq: optimize append #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions rosette/base/adt/seq.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,22 +69,19 @@
[((? racket-contract?) (union vs)) (unsafe-merge** vs (proc xs _))]
[((union vs) (? racket-contract?)) (unsafe-merge** vs (proc _ ys))]
[((union vs) (union ws))
(apply unsafe-merge*
(assert-some
(for*/list ([v vs] [w ws] [g (in-value (&& (car v) (car w)))] #:when g)
(cons g (proc (cdr v) (cdr w))))
#:unless (* (length vs) (length ws))
(arguments-error (quote proc) (format "expected ~a ~a" rosette-contract? rosette-contract?)
"first argument" vs "second argument" ws)))]))]
(apply unsafe-merge*
(for*/list ([v vs] [w ws] [g (in-value (&& (car v) (car w)))] #:when g)
(cons g (proc (cdr v) (cdr w)))))]))]
(define #,(lift-id #'proc)
(case-lambda
[() (racket-constructor)]
[(xs) (type-cast rosette-contract? xs (quote proc))]
[(xs ys) (unsafe/append (type-cast rosette-contract? xs (quote proc))
(type-cast rosette-contract? ys (quote proc)))]
[xss (for/fold ([out (racket-constructor)])
([xs (for/list ([ys xss]) (type-cast rosette-contract? ys (quote proc)))])
(unsafe/append out xs))])))]))
([xs (for/list ([ys (in-list (reverse xss))])
(type-cast rosette-contract? ys (quote proc)))])
(unsafe/append xs out))])))]))

(define-syntax (define/lift/split stx)
(syntax-case stx ()
Expand Down