Send CfP emails via a queue#1999
Draft
marksteward wants to merge 1 commit into
Draft
Conversation
marksteward
force-pushed
the
cfp-emails-in-db
branch
from
1bf7713 to
6905c15
Compare
marksteward
force-pushed
the
cfp-emails-in-db
branch
from
6905c15 to
91e25d6
Compare
marksteward
force-pushed
the
cfp-emails-in-db
branch
from
91e25d6 to
81a9de2
Compare
marksteward
force-pushed
the
cfp-emails-in-db
branch
from
81a9de2 to
1d58442
Compare
We often send a bunch of emails for CfP acceptance, which clogs up admin processes and can fail. Inserting them into a DB table also means we get the same transaction lifetime, so we don't need to worry about races or timeouts. This also combines bulk and notification email sending, syncs up the village owner emailing code, and partially fixes the flask-admin template/JS.
marksteward
force-pushed
the
cfp-emails-in-db
branch
from
1d58442 to
858bb6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We often send a bunch of emails for CfP acceptance, which clogs up admin processes and can fail. Inserting them into a DB table also means we get the same transaction lifetime, so we don't need to worry about periodic commits/correctness.
Emails don't get sent until the periodic task is run (
./flask periodic), so we should probably run that inside docker-compose. They can also be delayed up to a minute as a result, so it might be worth adding a way of poking the scheduler.There's currently no process to delete sent emails, which we'd probably want to be determined by the caller.
Fixes #1997.