server: Move to using Backend.Features() instead of Enable* flags#112
server: Move to using Backend.Features() instead of Enable* flags#112foxcpp wants to merge 3 commits intoemersion:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 62.09% 62.47% +0.38%
==========================================
Files 8 8
Lines 1108 1114 +6
==========================================
+ Hits 688 696 +8
+ Misses 312 311 -1
+ Partials 108 107 -1
Continue to review full report at Codecov.
|
|
I would like to see a |
|
I wonder how we should approach backwards compatibility. If we add a new feature, we won't be able to enable it by default without breaking the backend? |
Make all extensions opt-in rather than opt-out to make future additions easier and more consistent. Unrelated string(rune(char)) change is to make Go 1.15.6 'go test' happy.
|
Addressed feedback: added Feature.Contains() and inverted flags (making extensions opt-in rather than opt-out). |
emersion
left a comment
emersion
left a comment
There was a problem hiding this comment.
This now ensures adding new features to go-smtp won't break any backend, but it's not very ergonomic for users...
|
|
||
| const ( | ||
| // SMTPUTF8 (RFC 6531) extension. | ||
| FeatureSMTPUTF8 Feature = 2 << iota |
There was a problem hiding this comment.
Ouch, most likely a typo
| // SMTPUTF8 (RFC 6531) extension. | ||
| FeatureSMTPUTF8 Feature = 2 << iota | ||
| // BINARYMIME (RFC 3030) extension. CHUNKING extension is always supported. | ||
| FeatureBINARYMIME |
There was a problem hiding this comment.
The rest of the code seems to use the Go capitalization: "BinaryMIME"
(Same for "RequireTLS" I suppose)
3 participants
Closes #107.