docs(claude): fix stale reference-template paths in Test structure rule#110
Merged
Merged
Conversation
CLAUDE.md "Testing → Test structure" cited three reference templates; two had paths that don't exist on disk: - tests/OrderService.Tests.Unit/Application/PaymentFailedHandlerTests.cs - tests/ShippingService.Tests.Unit/Application/GetShipmentByOrderHandlerTests.cs docs/dev-loop.md's "AAA with narrative comments" row paraphrased the same rule and inherited the same dead links. Surfaced by a /check-rules audit pass — the canonical was the broken one; the paraphrase in .claude/agents/architecture-reviewer.md already cited real, working templates (OrderSagaTests.cs, OrderTests.cs). Replace with three templates that exist and exercise the three patterns: - ProductAuthorizationTests.cs — IDOR-prevention + rejected writes (kept) - OrderSagaTests.cs — saga consume-side idempotency under at-least-once - OrderTests.cs — aggregate state-machine invariants, unit-tier domain-only No rule text changes; only the cited exemplars. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR updates documentation references for the "AAA with narrative comments" testing pattern across two files. Both ChangesTest Documentation Pattern References
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`CLAUDE.md` "Testing → Test structure" cited three reference templates; two had paths that don't exist on disk. `docs/dev-loop.md`'s "AAA with narrative comments" row paraphrased the same rule and inherited the same dead links.
Why
Surfaced by a `/check-rules` audit pass over all 30 `See CLAUDE.md` paraphrase sites. Unusual inversion: the canonical was the broken one. The paraphrase in `.claude/agents/architecture-reviewer.md:141` already cited real, working files (`OrderSagaTests.cs`, `OrderTests.cs`) — those were the substitutes used here.
What changed
No rule semantics changed
Just citations. The rule text ("AAA with narrative comments", required markers, story-comment convention, multi-invariant numbering) is unchanged. `/check-rules` should now show all 30 paraphrase sites aligned with no broken cross-references.
🤖 Generated with Claude Code
Summary by CodeRabbit