Skip to content

fix: use fixed versioning group for all published packages#456

Merged
ascorbic merged 3 commits intomainfrom
fix/changeset-fixed-versions
Apr 11, 2026
Merged

fix: use fixed versioning group for all published packages#456
ascorbic merged 3 commits intomainfrom
fix/changeset-fixed-versions

Conversation

@ascorbic
Copy link
Copy Markdown
Collaborator

What does this PR do?

Replaces the experimental onlyUpdatePeerDependentsWhenOutOfRange / updateInternalDependents config (from #447) with a fixed versioning group containing all published packages.

Why #447 didn't work: workspace:* is internally resolved to the exact current version (e.g. 0.1.1) when changesets evaluates range satisfaction. Since 0.2.0 never satisfies 0.1.1, the "out of range" check always fires — the experimental options can't help for 0.x packages. This is a known upstream issue (changesets/changesets#822, #1797).

What fixed does: All packages in the group always share the same version number. A changeset touching any one of them bumps them all together, eliminating the peer-dep major-bump cascade entirely.

Type of change

  • Chore (dependencies, CI, tooling)

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes
  • pnpm --silent lint:json | jq '.diagnostics | length' returns 0
  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • I have added a changeset (if this PR changes a published package)
  • New features link to an approved Discussion: https://github.com/emdash-cms/emdash/discussions/...

AI-generated code disclosure

  • This PR includes AI-generated code

Screenshots / test output

N/A — config-only change.

The experimental onlyUpdatePeerDependentsWhenOutOfRange option cannot
prevent 0.x minor bumps from triggering major bumps in dependents —
workspace:* resolves to an exact version internally, so any minor bump
is always "out of range".

Replace with a fixed group: all published packages share a single
version number, eliminating the peer-dep cascade entirely.
Copilot AI review requested due to automatic review settings April 11, 2026 16:43
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 11, 2026

⚠️ No Changeset found

Latest commit: fadeaf6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 11, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
emdash-playground fadeaf6 Apr 11 2026, 04:51 PM

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 11, 2026

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@456

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@456

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@456

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@456

emdash

npm i https://pkg.pr.new/emdash@456

create-emdash

npm i https://pkg.pr.new/create-emdash@456

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@456

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@456

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@456

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@456

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@456

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@456

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@456

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@456

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@456

commit: fadeaf6

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Changesets configuration to avoid peer-dependency major-bump cascades for 0.x packages by moving from experimental “out-of-range” options to a fixed versioning group.

Changes:

  • Add a fixed versioning group intended to keep selected published packages on the same version.
  • Remove ___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH options previously used to limit dependent bumps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +10 to +23
"fixed": [
[
"emdash",
"@emdash-cms/admin",
"@emdash-cms/blocks",
"@emdash-cms/cloudflare",
"@emdash-cms/plugin-ai-moderation",
"@emdash-cms/plugin-atproto",
"@emdash-cms/plugin-audit-log",
"@emdash-cms/plugin-color",
"@emdash-cms/plugin-embeds",
"@emdash-cms/plugin-forms",
"@emdash-cms/plugin-webhook-notifier"
]
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description/title says the fixed group contains all published packages, but this list omits several non-private workspaces that appear publishable (e.g. @emdash-cms/auth, @emdash-cms/gutenberg-to-portable-text, create-emdash, @emdash-cms/x402). If the intent is truly “all published packages share one version”, add them to this fixed group; otherwise, update the PR description/title to reflect the narrower scope (e.g. only core + plugin packages).

Copilot uses AI. Check for mistakes.
@ascorbic ascorbic disabled auto-merge April 11, 2026 16:47
ascorbic and others added 2 commits April 11, 2026 17:48
Adds auth, gutenberg-to-portable-text, x402, and create-emdash which
were missing from the fixed group.
@ascorbic ascorbic enabled auto-merge (squash) April 11, 2026 16:49
@ascorbic ascorbic merged commit cf72f4a into main Apr 11, 2026
27 checks passed
@ascorbic ascorbic deleted the fix/changeset-fixed-versions branch April 11, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants