Skip to content

fix(admin): ensure content list pagination works correctly #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kombuchapunk wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −3
Open

fix(admin): ensure content list pagination works correctly #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97053a5
fix(admin): ensure content list pagination works correctly
kombuchapunk Apr 7, 2026
65b7d13
Remove explicit limit to use server default (50)
kombuchapunk Apr 7, 2026
413915e
style: format
emdashbot[bot] Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/admin/src/lib/api/content.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,9 @@ export async function fetchContentList(
): Promise<FindManyResult<ContentItem>> {
const params = new URLSearchParams();
if (options?.cursor) params.set("cursor", options.cursor);
if (options?.limit) params.set("limit", String(options.limit));
// Always include limit to ensure pagination works correctly
// Use provided value, or default to 100 for better UX in admin lists
params.set("limit", String(options?.limit ?? 100));
if (options?.status) params.set("status", options.status);
if (options?.locale) params.set("locale", options.locale);

Expand Down
5 changes: 3 additions & 2 deletions packages/admin/src/router.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,10 +243,11 @@ function ContentListPage() {
fetchContentList(collection, {
locale: activeLocale,
cursor: pageParam as string | undefined,
limit: 100,
}),
initialPageParam: undefined as string | undefined,
getNextPageParam: (lastPage) => lastPage.nextCursor,
// Explicitly return undefined when no cursor to ensure React Query correctly calculates hasNextPage
getNextPageParam: (lastPage) =>
lastPage.nextCursor && lastPage.nextCursor.length > 0 ? lastPage.nextCursor : undefined,
enabled: !!manifest,
});

Expand Down
Loading