Add LICENSE-MIT file with the license text.#5
Open
anforowicz wants to merge 1 commit intoemctague:masterfrom
Open
Add LICENSE-MIT file with the license text.#5anforowicz wants to merge 1 commit intoemctague:masterfrom
LICENSE-MIT file with the license text.#5anforowicz wants to merge 1 commit intoemctague:masterfrom
Conversation
This commit follows the advice from the Rust API guidelines (https://rust-lang.github.io/api-guidelines/necessities.html) which suggest to > add [...] LICENSE-MIT in the repository root, > containing the text of the licenses (which you can obtain, for > instance, from choosealicense.com, for Apache-2.0 and MIT). This commit helps software projects like Chromium to fullfil their requirements for explicitly covering license information for all of their dependencies (e.g. see https://crbug.com/369075726).
anforowicz
force-pushed
the
add-license-mit-file
branch
from
b9cc2e4 to
e85dbb9
Compare
Author
|
Ooops... please excuse the almost immediate force push. I've realized that I didn't edit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTAL?
This PR follows the advice from the Rust API guidelines (https://rust-lang.github.io/api-guidelines/necessities.html) which suggest to:
This helps software projects like Chromium to fullfil their requirements for explicitly covering license information for all of their dependencies (e.g. see https://crbug.com/369075726).
It would really help me if you could merge this PR and then publish a new version of the crate to crates.io. Thanks in advance!