sideEffects: false#21456
Open
NullVoxPopuli wants to merge 1 commit into
Open
Conversation
Contributor
📊 Size reportTarball size — dist/dev No changes
dist/prod No changes
smoke-tests/v2-app-template/dist 0.09%↑
smoke-tests/v2-app-hello-world-template/dist -8.05%↓
🤖 This report was automatically generated by wyvox/pkg-size |
7b6b742 to
0747280
Compare
0747280 to
210acf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
declare all modules as not causing sideEffects that would cause other modules to break -- if it's imported (and most of our stuff is imported right now)
we technically don't have any. guarantees that this is safe without the plugin from:
Routeis not present is the hello-world appWhere we started before other refactors landed:
smoke-tests/v2-app-hello-world-template/dist -35.3%↓
./assets/main-{hash}.js234.9 kB/64.3 kB151.9 kB/ -34.4%↓42.2 kB235.2 kB/64.5 kB152.3 kB/ -34.3%↓42.4 kBsetting
sideEffects: falsewith no refactors takes the hello-world app from 64.5 kB to 42.4 kBPRs that landed that bring this down from the initial 64.5 kB:
Note
Prior spikes with both sideEffects declaration and refactorings brought us down to ~30 kB