Fix SVG URL sanitization bypass#21440
Closed
metsw24-max wants to merge 1 commit into
Closed
Conversation
Contributor
|
thanks for your submission, @metsw24-max ! however, this looks like a duplicate of #21442 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a namespace-dependent URL sanitization bypass affecting SVG anchor elements.
requiresSanitization()previously comparedtagNamedirectly against uppercase allow/block lists. While HTML elements report uppercase tag names (e.g.A), SVG elements preserve their authored case (e.g.a), causing sanitization checks to be skipped for SVG anchors.This change normalizes tag names to uppercase before evaluating URL sanitization requirements, making the behavior consistent across namespaces and matching the normalization already performed by
sanitizeAttributeValue().Changes
tagNameto uppercase inrequiresSanitization().<svg><a href="{{...}}">with both unsafe and valid URLs.Before
could bypass the URL sanitization gate because the SVG anchor's tag name was reported as
ainstead ofA.After
SVG anchor elements are correctly identified as requiring URL sanitization, and unsafe URLs are rewritten as expected:
Testing
Added an integration test that verifies:
javascript:URLs in SVG anchorhrefattributes are sanitized.