Use customizable select for version pickers#167
Open
tcjr wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for upgrade-guide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds styles to the two version pickers.
It use the new(ish) built-in support for customizable select elements. This is available in Chrome 135 and Safari 27. The beauty of how customizable select works is that it literally uses the stock
<select>element, so it works perfectly in browsers that don't yet support the standard (aka, Firefox). This means it is fully accessible and requires no markup hacks, positioning logic, or focus handling.The problem being addressed is that the list of versions goes on and on and on. I updated it so the version options are displayed horizontally within their option group. The options and option groups are minimally styled, leaving everything else to the browser.
Before:
After:
See: