Get tests running#166
Merged
Merged
Conversation
✅ Deploy Preview for upgrade-guide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mansona
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
test:emberscript so the tests are run by devs and CI.The tests haven't been running in a while, so I also had to make a couple very minor code changes to get them passing.
Whenever a new release is published, somebody has to add the version to this app. Then, they also need to update the tests in 12 places to reflect the current deltas from the (arbitrary?) version 3.15. This whole thing should probably be reworked, but this isn't the PR for that. I couldn't resist one small refactor, though. Now, instead of updating the values in 12 places, there's a constant at the top of the test file.
Fixes: #162