Skip to content

Add option groups to version select#165

Merged
mansona merged 1 commit into
ember-learn:mainfrom
tcjr:option-groups
Jun 9, 2026
Merged

Add option groups to version select#165
mansona merged 1 commit into
ember-learn:mainfrom
tcjr:option-groups

Conversation

@tcjr

@tcjr tcjr commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This small PR breaks up the long version list by adding <optgroup> elements to the <select> for both the TO and FROM versions.

Before
before

After
after

@mansona

mansona commented Jun 9, 2026

Copy link
Copy Markdown
Member

I don't know why Netlify isn't reporting status here 🤔 https://deploy-preview-165--upgrade-guide.netlify.app/

@mansona mansona left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! and the preview looks great 🎉

@mansona mansona merged commit e1b417c into ember-learn:main Jun 9, 2026
2 checks passed
@tcjr

tcjr commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

@mansona FYI, the tests still aren't running anywhere for this project. (See #162). Looking at them now. The tests could use some TLC.

@netlify

netlify Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploy Preview for upgrade-guide ready!

Name Link
🔨 Latest commit ae8c54b
🔍 Latest deploy log https://app.netlify.com/projects/upgrade-guide/deploys/6a287699d30e9e00085f4885
😎 Deploy Preview https://deploy-preview-165--upgrade-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants