Skip to content

Change Test mode to Development mode and fix NODE_ENV in tests #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mansona merged 1 commit into from
Jun 25, 2025
Merged

Change Test mode to Development mode and fix NODE_ENV in tests #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 files/.env.test → files/.env.development
View file
Open in desktop
Copy link
Copy Markdown
Member

@mansona mansona Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can delete this 👍

Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test that asserts that assert from @ember/debug makes it to the test ouput

Copy link
Copy Markdown
Member

@mansona mansona Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is a nice to have @NullVoxPopuli 🤔 but I wouldn't block too long on that

Copy link
Copy Markdown

@robbytx robbytx Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test that asserts that assert from @ember/debug makes it to the test ouput

@NullVoxPopuli I added a test in embroider-build/embroider#2501

Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli Jun 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's great! however, we still need tests for the addon-blueprint to make sure we've configured things correctly -- I put up a WIP here: ember-cli/ember-addon-blueprint#66

File renamed without changes.
2 changes: 1 addition & 1 deletion files/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"lint:types": "glint<% } %>",
"start": "vite",
"test": "concurrently \"<%= packageManager %>:lint\" \"<%= packageManager %>:test:*\" --names \"lint,test:\" --prefixColors auto",
"test:ember": "vite build --mode test && testem ci"
"test:ember": "vite build --mode development && testem ci"
},
"exports": {
"./tests/*": "./tests/*",
Expand Down