Apply typescript-eslint's recommended config to gts files#147
Apply typescript-eslint's recommended config to gts files#147bendemboski wants to merge 1 commit intoember-cli:mainfrom
typescript-eslint's recommended config to gts files#147Conversation
| extends: [...ts.configs.recommendedTypeChecked, ember.configs.gts], | ||
| extends: [ | ||
| ...ts.configs.recommendedTypeChecked, | ||
| // https://github.com/ember-cli/ember-addon-blueprint/issues/119 |
There was a problem hiding this comment.
in this comment, can we add a link to the other two discussions as well?
I think the context is probably valuable since this is so weird
There was a problem hiding this comment.
so I'm not comfortable linking to an issue that is closed as a not planned here like this 🤔
There was a problem hiding this comment.
What's your proposal @mansona ? Leave it as-is with just a link to our issue (that then itself links to the other issues if people dig a little)? Or perhaps provide more of an inline explanation rather than links to issues? Something else?
There was a problem hiding this comment.
So the thing I want to see here is a full explanation of why we're doing a hack, what we're working around, and then we are able to link to any issues that explain why upstream is not going to fix this.
If we're linking to a closed issue in a file that is output into a user's newly generated app we need to explain what it means and we need to communicate a sense of reassurance as to why it's ok to have this hack here. This could be one of the first experiences that someone has with an ember app and, even though it's not great, they could reasonably decide not to use Ember for a project because of a dangling link to a closed issue in a generated file 🤷
NullVoxPopuli
left a comment
NullVoxPopuli
left a comment
There was a problem hiding this comment.
Thanks for spending the time on this and getting me up to speed on the problem <3
"Patch" `typescript-eslint`'s recommended config to allow us to extend it to `gts` files, and also add test cases to verify that we're applying the ruleset to both `ts` and `gts` files. This is the equivalent of ember-cli/ember-addon-blueprint#120 for this repo
bendemboski
force-pushed
the
fix-tseslint-recommended-gts
branch
from
de4861d to
c27ba64
Compare
3 participants
"Patch"
typescript-eslint's recommended config to allow us to extend it togtsfiles, and also add test cases to verify that we're applying the ruleset to bothtsandgtsfiles.This is the equivalent of ember-cli/ember-addon-blueprint#120 for this repo