Handle sourcemaps when publicUrl is used#70
Open
astronomersiva wants to merge 2 commits intoember-cli:masterfrom
Open
Handle sourcemaps when publicUrl is used#70astronomersiva wants to merge 2 commits intoember-cli:masterfrom
astronomersiva wants to merge 2 commits intoember-cli:masterfrom
Conversation
Member
|
why do you not use the prefix thing from the asset rewriter directly instead of the |
Author
|
I hope you are talking about the |
Author
|
A gentle reminder @Turbo87... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently introduced a change in broccoli-uglify-sourcemap that allows specifying a
publicUrlin sourcemaps. However, since the regex used only checks forsourceMappingUrl=followed by the name of the sourcemap itself, it will not get fingerprinted.