rewrite asset paths inside srcset lists#56
Open
chadkirby wants to merge 1 commit intoember-cli:masterfrom
Open
rewrite asset paths inside srcset lists#56chadkirby wants to merge 1 commit intoember-cli:masterfrom
chadkirby wants to merge 1 commit intoember-cli:masterfrom
Conversation
Collaborator
|
This looks good to me. Anyone from the Ember team want to confirm everything looks good inside a real world app? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51
According to MDN, the srcset attribute contains:
The
rewriteAssetPathlogic seems to behave properly if we simply allow assetPaths to begin/end with commas (in addition to quotes, open paren, and equals). The match will include the width/pixel-density descriptor at the end, but that does not appear to cause problems (in the admittedly few cases that I've tested).