Skip to content

wrapper: fix const-correctness for mutating image APIs #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ozan956 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

wrapper: fix const-correctness for mutating image APIs #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions wrapper/ImageWrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,15 +285,15 @@ int Image::extractHoughLines(const std::vector<std::vector<int>> &acc,
/**
* @brief Draws line segment between two points.
*/
void Image::drawLine(int x0, int y0, int x1, int y1, uint8_t color) const noexcept
void Image::drawLine(int x0, int y0, int x1, int y1, uint8_t color) noexcept
{
::drawLine(raw(), x0, y0, x1, y1, color);
}

/**
* @brief Draws line represented in Hough space.
*/
void Image::drawHoughLine(float rho, float theta, uint8_t color) const noexcept
void Image::drawHoughLine(float rho, float theta, uint8_t color) noexcept
{
::drawLineOnImage(raw(), rho, theta, color);
}
Expand Down Expand Up @@ -648,15 +648,15 @@ void Image::_phase_(Image &out) const
/**
* @brief Applies logarithm transform in place.
*/
void Image::_log_() const
void Image::_log_()
{
::_log_(raw());
}

/**
* @brief Adds scalar value in place.
*/
void Image::_add_(float value) const
void Image::_add_(float value)
{
::_add_(raw(), value);
}
Expand Down Expand Up @@ -688,7 +688,7 @@ void Image::ifft(Image &out) const
/**
* @brief Converts polar components to complex/cartesian form.
*/
void Image::polarToCart(const Image &magnitude, Image &phase) const
void Image::polarToCart(const Image &magnitude, const Image &phase)
{
::polarToCart(magnitude.raw(), phase.raw(), raw());
}
Expand Down
10 changes: 5 additions & 5 deletions wrapper/ImageWrapper.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,15 +415,15 @@ class Image
* @param[in] color Line color value
* @see ::drawLine For underlying C implementation
*/
void drawLine(int x0, int y0, int x1, int y1, uint8_t color) const noexcept;
void drawLine(int x0, int y0, int x1, int y1, uint8_t color) noexcept;
/**
* @brief Draws an infinite line defined by Hough parameters.
* @param[in] rho Distance from origin
* @param[in] theta Angle in radians
* @param[in] color Line color value
* @see ::drawLineOnImage For underlying C implementation
*/
void drawHoughLine(float rho, float theta, uint8_t color) const noexcept;
void drawHoughLine(float rho, float theta, uint8_t color) noexcept;

// Morphology
/**
Expand Down Expand Up @@ -674,14 +674,14 @@ class Image
* @brief Applies natural logarithm in place.
* @see ::_log_ For underlying C implementation
*/
void _log_() const;
void _log_();

/**
* @brief Adds scalar value to image in place.
* @param[in] value Scalar offset to add to all pixels
* @see ::_add_ For underlying C implementation
*/
void _add_(float value) const;
void _add_(float value);

/**
* @brief Computes inverse Fourier transform.
Expand All @@ -696,7 +696,7 @@ class Image
* @param[in] phase Phase image in radians
* @see ::polarToCart For underlying C implementation
*/
void polarToCart(const Image &magnitude, Image &phase) const;
void polarToCart(const Image &magnitude, const Image &phase);

/**
* @brief Multiplies two images element-wise.
Expand Down
Loading