Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the script files to centralize environment checks and Maven execution logic into reusable
agent.batandagent.shscripts. It also removes redundant PowerShell scripts, simplifying the codebase and improving maintainability.Centralization of Environment Checks and Maven Execution:
scripts/support/agent.batandscripts/support/agent.shto handle environment checks and Maven execution. These scripts ensure theAGENT_APPLICATIONvariable is set, verify the presence of thepom.xmlfile, and execute the Spring Boot application. [1] [2]Refactoring of Existing Scripts:
mcp_server.cmd,mcp_server.sh,shell.cmd,shell.sh, andshell_docker.cmdto delegate environment checks and Maven execution to the newagent.batandagent.shscripts. This reduces code duplication across scripts. [1] [2] [3] [4] [5]shell.shandshell.cmdscripts for the "shell" profile, leveraging the centralized logic. [1] [2]Removal of Redundant Scripts:
scripts/shell_docker.ps1and the environment check scriptscripts/support/check_env.ps1, as their functionality is now integrated intoagent.batandagent.sh. [1] [2]